-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Update monorepo internal React deps #14639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Updated the title to be clear that this is just for our internal React dependencies. Users of the library can already upgrade to the fixed versions of React and the associated packages from the vulnerability. The version selectors on the current react-router packages all allow the fixed versions to be installed. |
53935ef to
625386a
Compare
|
I think the latest E2E failure is related to #14633. Still have to dig in further. |
6dd12eb to
108345a
Compare
108345a to
e8f7cdb
Compare
e8f7cdb to
155e949
Compare
| "build": { | ||
| "command": "tsup", | ||
| "files": [ | ||
| "../../pnpm-workspace.yaml", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trigger a new wireit build if we update any catalog versions
|
ok rebased all these commits and repointed to dev (and began leveraging the pnpm catalog there) since the changes ended up touching e2e tests and stuff so it felt a bit more risky to just yolo to main :) |
|
needed a close/reopen to trigger CI for some reason... |
|
|
@jacob-ebey tracked down the RSC issue we were seeing in #14643 and the fix was pinning to react canary. This PR adds an additional named PNPM catalog for |
Updates all of our internal deps (integration tests, playgrounds, tutorial, dev deps, etc.) to the latest versions of packages impacted by GHSA-fv66-9v8q-g76r. Our packages are not directly impacted as all impacted packages are peerDeps managed by the user application - but it's still best to update our internals deps and this will help avoid confusion as folks search through our various monorepo
package.jsonfiles and see vulnerable versions.react -> 19.2.1react-dom -> 19.2.1react-server-dom-parcel -> 19.2.1@vitejs/plugin-rsc -> 0.5.6This also now moves these deps to the pnpm catalog for easier updating now and in the future