Skip to content

fix(fs-routes): resolve route file outside of app dir relative to app dir #13937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

frodi-karlsson
Copy link
Contributor

@frodi-karlsson frodi-karlsson commented Jul 4, 2025

Fixes #13063

Sorry about the force push. Needed to rebase onto latest dev for contributors.yml update. Re-tested without these changes on the updated version.

Side-note: Are only issues with accepting-prs eligible for community contributions?

sergiodxa on Discord had an answer hours earlier:

There’s no “good first bug” or “good first issue” on the repo, you can check the repo for issues and if something seems easy send a PR

Copy link

changeset-bot bot commented Jul 4, 2025

🦋 Changeset detected

Latest commit: f18e280

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@react-router/fs-routes Patch
create-react-router Patch
react-router Patch
react-router-dom Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/dev Patch
@react-router/express Patch
@react-router/node Patch
@react-router/remix-routes-option-adapter Patch
@react-router/serve Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 4, 2025

Hi @frodi-karlsson,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@frodi-karlsson frodi-karlsson force-pushed the route-outside-app-dir branch from 706be00 to 19d5123 Compare July 5, 2025 00:28
@MichaelDeBoey MichaelDeBoey changed the title fix: resolve route file outside of app dir relative to app dir fix(fs-routes): resolve route file outside of app dir relative to app dir Jul 10, 2025
@brophdawg11 brophdawg11 requested review from markdalgleish and removed request for brophdawg11 July 10, 2025 14:23
@brophdawg11 brophdawg11 linked an issue Jul 10, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flatRoutes rootDirectory cannot be outside of appDirectory
3 participants