Fix(react-router): Generalize href to match possible routes #13797
+42
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f4b7fd9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
ngbrown
force-pushed
the
href-with-period-fix
branch
from
e1316f4 to
3253ada
Compare
ngbrown
force-pushed
the
href-with-period-fix
branch
from
3253ada to
5401bf0
Compare
|
@pcattori Do you have feedback for how I implemented this fix to |
ngbrown
force-pushed
the
href-with-period-fix
branch
from
5401bf0 to
fcc3707
Compare
ngbrown
force-pushed
the
href-with-period-fix
branch
from
fcc3707 to
f4b7fd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13795 and supersedes #13613
It is possible to have routes with an extension (
/:id.txt) or with a single optional parameter (/:lang?).href()did not handle those cases correctly.This fixes that with an implementation of
href()that more closely resembles howcompilePath()handles the path.For a demonstration of the issue, see the
bug-report-test.tsin #13795 or this example project.