-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Use textdecoder decoding code param payload #6390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CoveMB
wants to merge
10
commits into
remix-project-org:master
Choose a base branch
from
CoveMB:use-textdecoder-decoding-code-param-payload
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Use textdecoder decoding code param payload #6390
CoveMB
wants to merge
10
commits into
remix-project-org:master
from
CoveMB:use-textdecoder-decoding-code-param-payload
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for reliable-cocada-166884 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Hello, let me know if the MR need anything else @Aniket-Engg |
bedroomeyes555
approved these changes
Oct 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
code
URL param to use TextDecoder; add e2e coverageSummary
?code=
URL parameter.Problem
code
URL param could fail to correctly decode content containing:atob()
bytes and then useddecodeURIComponent
, which is error-prone for arbitrary UTF‑8.Scope
libs/remix-ui/workspace/src/lib/actions/workspace.ts
: Replace decoder implementation and update usage.apps/remix-ide-e2e/src/tests/url.test.ts
: Add a new test covering special chars, punctuation, and persistence behavior.Changes
decodePercentEscapedBase64(b64Payload)
decodeBase64(b64Payload)
usingTextDecoder('utf-8')
params.code
is processed to use the new decoder.tion and special character #group1” that:
#code=
payload containing special characters and emoji.
root.
Implementation Details
decodeURIComponent(b64Payload)
→atob()
→Uint8Array.from()
→new Tex tDecoder().decode(bytes)
.cent-encoding reconstruction.
Backward Compatibility
decodePercentEscapedBase64
todecodeBase64
is contained within the same module with its usage updated. No external API chang
es anticipated.
Note