Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Oct 16, 2022

PULL ALPHA

GrandSchtroumpf and others added 30 commits December 7, 2020 09:42
add permission documentation
update absolute path func for sourcify WriteFile error
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.7.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](npm/ini@v1.3.5...v1.3.7)

Signed-off-by: dependabot[bot] <[email protected]>
Fix CompilationFileSources API interface
Fix vscode bug on deactivation
add support for theia in webview
lastCompilationResult is what is being returned by getcompilationresult, not a compilationresult
return lastcompilationresult, not a compilationresult
@@ -0,0 +1,157 @@
## Plugin electon

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```python

@@ -0,0 +1,157 @@
## Plugin electon

How to use the plugin:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
How to use the plugin:
How to use the plugin:

Comment on lines +1 to +2
## Plugin electon

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Plugin electon
## Plugin electon

How to use the plugin:

In electron you
1. add the base plugin to a basic engine in electron: ElectronBasePlugin

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. add the base plugin to a basic engine in electron: ElectronBasePlugin
1. add the base plugin to a basic engine in electron: ElectronBasePlugin
Suggested change
1. add the base plugin to a basic engine in electron: ElectronBasePlugin
1. add the base plugin to a basic engine in electron: ElectronBasePlugin

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Comment on lines +9 to +11
runs-on: ubuntu-latest
steps:
- uses: yann300/rebase-pull-requests@master No newline at end of file

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI about 1 month ago

The correct fix is to explicitly specify permissions at the workflow or job level. Since this workflow uses an action that rebases pull requests, it needs write access to pull requests, and potentially read-only access to contents. Add a permissions block under the root level (recommended so all future jobs inherit) with the following:

permissions:
  contents: read
  pull-requests: write

Place this directly after the name: and before on: (lines 1-2), or directly after on: (line 6), to apply globally across all jobs. This follows the principle of least privilege, ensuring the GITHUB_TOKEN only has read access to contents and write access to pull requests, nothing else.


Suggested changeset 1
.github/workflows/rebase-pull-requests.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/rebase-pull-requests.yml b/.github/workflows/rebase-pull-requests.yml
--- a/.github/workflows/rebase-pull-requests.yml
+++ b/.github/workflows/rebase-pull-requests.yml
@@ -1,4 +1,7 @@
 name: Rebase Pull Requests
+permissions:
+  contents: read
+  pull-requests: write
 on:
   push:
     branches: [master]
EOF
@@ -1,4 +1,7 @@
name: Rebase Pull Requests
permissions:
contents: read
pull-requests: write
on:
push:
branches: [master]
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants