Skip to content

fix themes again #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −9
Open

fix themes again #354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions packages/plugin/webview/src/lib/connector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,21 +156,24 @@ function applyTheme(theme: Theme) {

/** Start listening on theme changed */
async function listenOnThemeChanged(client: PluginClient) {
let cssLink: HTMLLinkElement;
let cssHttpLink: HTMLLinkElement;
let cssHttpsLink: HTMLLinkElement;
// Memorized the css link but only create it when needed
const getLink = () => {
if (!cssLink) {
cssLink = document.createElement('link')
cssLink.setAttribute('rel', 'stylesheet')
document.head.prepend(cssLink)
const getLink = (element) => {
if (!element) {
element = document.createElement('link')
element.setAttribute('rel', 'stylesheet')
document.head.prepend(element)
}
return cssLink;
return element;
}

// If there is a url in the theme, use it
const setLink = (theme: Theme) => {
if (theme.url) {
getLink().setAttribute('href', theme.url.replace(/^http:/,"").replace(/^https:/,""))
const url = theme.url.replace(/^http:/, "protocol:").replace(/^https:/, "protocol:");
getLink(cssHttpLink).setAttribute('href', url.replace(/^protocol:/, "http:"));
getLink(cssHttpsLink).setAttribute('href', url.replace(/^protocol:/, "https:"));
document.documentElement.style.setProperty('--theme', theme.quality)
}
}
Expand All @@ -186,6 +189,6 @@ async function listenOnThemeChanged(client: PluginClient) {
setLink(theme);
applyTheme(theme);
})
return cssLink
return cssHttpsLink
}