Make the 400 error handler better#365
Open
AdamWill wants to merge 1 commit intorelease-engineering:developfrom
Open
Make the 400 error handler better#365AdamWill wants to merge 1 commit intorelease-engineering:developfrom
AdamWill wants to merge 1 commit intorelease-engineering:developfrom
Conversation
This error handler does nothing but hide the real problem. Make it more like the others. Still, I'm not sure why any of these exist. All they really seem to do is obfuscate the real problem. OK, I guess they add app logging, but even the ones that pass through 'error' are probably hiding a lot of other useful information? Signed-off-by: Adam Williamson <awilliam@redhat.com>
Contributor
Author
|
Trying to debug Fedora's staging resultsdb and all I get is "Bad request", which is...not telling me anything at all useful. |
Contributor
Author
|
This does work. Before: After: Much more useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This error handler does nothing but hide the real problem. Make it more like the others.
Still, I'm not sure why any of these exist. All they really seem to do is obfuscate the real problem. OK, I guess they add app logging, but even the ones that pass through 'error' are probably hiding a lot of other useful information?