Skip to content

refactor: eliminate code duplication in RandomCoin deserialization #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

refactor: eliminate code duplication in RandomCoin deserialization #24

wants to merge 3 commits into from

Conversation

@ninastef
Copy link

@ninastef ninastef commented Nov 24, 2025 •
edited
Loading

Describe your changes

Hello! This PR refactors the deserialization logic for RpoRandomCoin and RpxRandomCoin by extracting common functionality into a reusable utility function, eliminating code duplication and improving maintainability.

  • New utility function read_felt_array in utils/mod.rs for deserializing arrays of Felt elements
  • Provides a generic helper for reading arrays of Felt from a ByteReader

Checklist before requesting a review

  • Repo forked and branch created from next according to naming convention.
  • Commit messages and codestyle follow conventions.
  • Documentation/comments updated according to changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ninastef