feat: running workflows on container with reusable actions #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgilmer
approved these changes
Feb 3, 2025
| echo "includes=$(jq -n -c "[$(printf '%s\n' "${INCLUDES[@]}" | paste -sd,)]" '$ARGS.named')" >> $GITHUB_OUTPUT | ||
| echo "excludes=$(jq -n -c "[$(printf '%s\n' "${EXCLUDES[@]}" | paste -sd,)]" '$ARGS.named')" >> $GITHUB_OUTPUT | ||
|
|
||
| # build packages and sources | ||
| build: | ||
| runs-on: [self-hosted, Linux, "${{ fromJSON(needs.matrix-builder.outputs.runners)[matrix.arch] }}", "${{ matrix.codename }}"] | ||
| runs-on: ${{ fromJSON(needs.matrix-builder.outputs.runners)[matrix.arch] }} |
There was a problem hiding this comment.
for my understanding, is there somewhere to see what this value looks like?
khos2ow
commented
Feb 3, 2025
| @@ -159,15 +159,17 @@ jobs: | |||
| echo "codenames=$(jq -n -c '$ARGS.positional' --args -- "${CODENAMES[@]}")" >> $GITHUB_OUTPUT | |||
| echo "arches=$(jq -n -c '$ARGS.positional' --args -- "${ARCHES[@]}")" >> $GITHUB_OUTPUT | |||
| echo "suites=$(jq -n -c "${SUITES}" '$ARGS.named')" >> $GITHUB_OUTPUT | |||
| echo "runners=$(jq -n -c "$(jq -n -c --arg amd64 "X64" --arg arm64 "arm64" '$ARGS.named')" '$ARGS.named')" >> $GITHUB_OUTPUT | |||
| echo "runners=$(jq -n -c "$(jq -n -c --arg amd64 "ubuntu-24.04" --arg arm64 "ubuntu-24.04-arm" '$ARGS.named')" '$ARGS.named')" >> $GITHUB_OUTPUT | |||
There was a problem hiding this comment.
This is json values for runners for each arch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the workflow files to using the reusable actions and running the in containers.
Changes:
builder-deb-v4.yml: deprecated and removedbuilder-deb-v5.yml: added as the next generation of debian package builderpublish-packages.yml: start using reusable actions on containerrebuild-sources.yml: start using reusable actions on containertest-desktop-installable2.yml: start using reusable actions on containeranother major change is:
dropped the support for making and publishing a release after each workflow run:
the reason is that all the changelogs, manifests change, etc are being tracked in repository anyways and we are going to use the tag and release on this repo for actual "Regolith 3.x[-beta?]" version releases.