Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/v1.10 port #34

Open
wants to merge 10 commits into
base: upstream/v1.10
Choose a base branch
from
Open

Feat/v1.10 port #34

wants to merge 10 commits into from

Conversation

kgilmer
Copy link
Member

@kgilmer kgilmer commented Feb 6, 2025

PR for illustrative purposes only, will not be merged but live as stand-alone branch.

@khos2ow
Copy link
Member

khos2ow commented Feb 6, 2025

Please give me a heads up before merging this, because I'm changing the published repo backend. Although merging into upstream/v1.10 is gonna be safe. But at a later time we have to rename that branch, or create another one (e.g. packaging/v1.10-regolith) and update workflows file here and package-model file in voulage. This step needs a coordination on my part.

@kgilmer
Copy link
Member Author

kgilmer commented Feb 7, 2025

Standing by @khos2ow . My plan was once I got things building on trixie, that I'd "publish" "merge" this PR by moving the branch name to packaging/v1.10-regolith, updating the Voluage package models, and then building. LMK how you'd like me to proceed.

BTW: I think it's ready to go

@kgilmer
Copy link
Member Author

kgilmer commented Feb 7, 2025

Tested this builds successfully on my trixie dev machine.

@kgilmer
Copy link
Member Author

kgilmer commented Feb 7, 2025

@SoumyaRanjanPatnaik , for visibility. I have not yet tested that it runs but FWIW the only notable change from 1.9 I noticed was that include/background_image.h was removed. There was some code in dbusmenu.c that was calling it for some menu item. I removed the call and associated code. LMK if you would expect any regression from that change, or any other concerns..

@khos2ow
Copy link
Member

khos2ow commented Feb 7, 2025

@kgilmer go ahead and merge and rename to packaging/v1.10-regolith. You can also update Voulage package models as well.

But let me copy over .github/workflows/ into it later today. That, then, will effectively bring to the CI system.

@SoumyaRanjanPatnaik
Copy link
Collaborator

Hey. I'll test this out and let you know how it goes.

@kgilmer
Copy link
Member Author

kgilmer commented Feb 11, 2025

@SoumyaRanjanPatnaik FYI this is packaged in the new apt repo. I am seeing that the trawl integration isn't working properly: sway emits syntax parse errors for the resource decls at session start. Will look more into it.

@SoumyaRanjanPatnaik
Copy link
Collaborator

Hey Ken. Apologises for not being very responsive. My day job is leaching all of my energy these days😢.

@SoumyaRanjanPatnaik
Copy link
Collaborator

I'm currently unable to build for to a missing wlroots dependency on noble. Will upgrade to 24.10 today and see if I can get the binary to build.

@kgilmer
Copy link
Member Author

kgilmer commented Feb 11, 2025

No need to apologize. 😄 This project is for when we have time and when we find it enjoyable.

I've tested 1.10-2 and it seems to be working (..well for the first 5 mins at least)

@kgilmer
Copy link
Member Author

kgilmer commented Feb 11, 2025

@SoumyaRanjanPatnaik looks like Plucky is the only game in town for the wlroots dep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants