Skip to content

tentative migrate pyright to ty#6465

Draft
benedikt-bartscher wants to merge 33 commits into
reflex-dev:mainfrom
benedikt-bartscher:migrate-pyright-to-ty
Draft

tentative migrate pyright to ty#6465
benedikt-bartscher wants to merge 33 commits into
reflex-dev:mainfrom
benedikt-bartscher:migrate-pyright-to-ty

Conversation

@benedikt-bartscher
Copy link
Copy Markdown
Contributor

@benedikt-bartscher benedikt-bartscher commented May 6, 2026 •
edited
Loading 

time ty check
...
ty check  6.93s user 0.22s system 1415% cpu 0.505 total

time pyright
...
pyright  23.59s user 0.74s system 168% cpu 14.470 total

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 6, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 24 untouched benchmarks

Comparing benedikt-bartscher:migrate-pyright-to-ty (16a3c8d) with main (e88acf7)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (7281317) during the generation of this report, so e88acf7 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@benedikt-bartscher
Merge remote-tracking branch 'upstream/main' into migrate-pyright-to-ty
28ac1e1
@benedikt-bartscher
bump ty, adjust some typing
c8c4dff
@benedikt-bartscher
pyi
6a4b3b7
@benedikt-bartscher
fix import
7e6578f
@benedikt-bartscher
less type ignores
3ce9c63
@benedikt-bartscher
some more typing stuff
64734b9
@benedikt-bartscher
eliminate more type ignores
d39f7c7
@benedikt-bartscher
add passthrough_event_spec overload
440e7b6
@benedikt-bartscher
re-add docs
a10eff7
@benedikt-bartscher
fix docs
114e076
@benedikt-bartscher
revert docs
0e31f36
@benedikt-bartscher
Merge upstream/main into migrate-pyright-to-ty
fa1a17f 
Resolve conflicts from upstream's memo refactor (reflex-dev#6517, promote rx._x.memo
to rx.memo): memo implementation moved to reflex_base.components.memo and
CustomComponent was removed. Re-apply the ty migration changes onto the new
locations:

- reflex/experimental/memo.py: take upstream's deprecated alias
- reflex_base/components/memo.py: type fn params as FunctionType and add
  ty:ignore for dynamic __signature__ assignment
- tests: drop CustomComponent tests removed upstream; carry ty:ignore
  comments onto the relocated memo/telemetry tests
- pyproject.toml / uv.lock: keep both towncrier (upstream) and ty (HEAD)
- pyi_hashes.json: regenerated

ty check, ruff, and the unit suite pass.
@benedikt-bartscher
less type ignores
7db7e00
@benedikt-bartscher
pre-commit
d6713fa
@benedikt-bartscher
more typing
3d4589f
@benedikt-bartscher
use future annotations
b2867cc
@benedikt-bartscher
drop pyright ignores, use final
3ac5147
@benedikt-bartscher
more final, less ignore
1c52796
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alek99 Alek99 Awaiting requested review from Alek99 Alek99 will be requested when the pull request is marked ready for review Alek99 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@benedikt-bartscher