-
Notifications
You must be signed in to change notification settings - Fork 670
Improve Typescript definitions #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.0.0 #224 +/- ##
====================================
Coverage 100% 100%
====================================
Files 1 1
Lines 15 15
====================================
Hits 15 15 Continue to review full report at Codecov.
|
Hey @threehams and @aikoven, what do you think about it ? |
2 similar comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me compared to my PR @alex3165 mentions. 👍
What about |
Also added a namespace to close this issue #149 |
A more modern way of doing this is |
@aikoven Thanks for your feedbacks I didn't know |
Thanks! It looks good now 👍 |
@ellbee Would it be possible to have your approval ? |
@aikoven Should I merge this PR ? |
I think so. I would also add test for non-module usage, that uses the namespace you've added. Though I'm not sure if this is important. If you want, add another test file without imports, that uses |
Add resultFunc, recomputations and resetRecomputations to the Typescript definition file.
This is just an adaptation of #167 from @lukevenn against the new branch 3.0.0