Skip to content

[Fix] react-json-tree: Handle sparse empty arrays greater than limit #1828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −1
Open

[Fix] react-json-tree: Handle sparse empty arrays greater than limit #1828

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2160aaa
Update JSONNestedNode.tsx to better handle sparse array inputs
arcataroger Feb 7, 2025
8084678
Merge branch 'main' into patch-3
arcataroger Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/react-json-tree/src/JSONNestedNode.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ interface Entry {
}

function isRange(rangeOrEntry: Range | Entry): rangeOrEntry is Range {
return (rangeOrEntry as Range).to !== undefined;
return (rangeOrEntry as Range)?.to !== undefined;
}

function renderChildNodes(
Expand All @@ -54,6 +54,10 @@ function renderChildNodes(
from,
to,
).forEach((entry) => {
// Don't process null/undefined entries, which can come from sparse arrays
if(!entry) {
return
}
if (isRange(entry)) {
childNodes.push(
<ItemRange
Expand Down