-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs Update: Minor Styling and Fixes #22
Conversation
This all looks great! Thank you! |
Sure thing, and glad to help! I think I'm going to finally call it done. Here's what was added:
*I left the rest of the GH links as-is since it redirected to the new username, and just updating the HTML files was going to be an additional 900+ file changes Most styling updates were fixed using the existing classes in the bundle, but as you probably know, the responsive styling issues won't update until the CDN css has been updated. Here's the PR for the template which has those fixes: Redux-Form-Website-Template Update There was also an issue with the version checker styling. With the flex-direction fix, it ended up hidden by the topNav on small screens. Here's a PR for that too : Example Redux-Form-Doc-Version-Checker There is still one remaining console error I didn't dive into, but wanted to at least mention. For versions 6.0.1 - 8.3.0 there is a "missing hydrate function" error. (Example) I'm not sure when the React team moved "renderToStaticMarkup" to the separate ReactDOMServer package, but since the RF site uses 15.6 for all versions, I wondered if that is somehow related. |
@erikras Sorry, I didn't realize how huge this PR became, but I did want to make sure, you're not waiting on me for anything here. Do I need to make sure to fix those http links, so the mixed content check passes? If there anything I can do to make the review process easier, please ket me know. 👍 |
Here is the PR for the minor fixes to the RF Docs site addressing a lot of various issues experienced on the site.
Current List of Applied Fixes (September 1st):
*Only set on 8.2.2 for now. Want to confirm this is expected fix before updating others.
Additional Fixes (September 2nd):
On the Chopping Block:
- Updating the rest of the AdsUpdate documentation links on the pre-6.0.0 version to point to correct docs (like with 4.2.0)Just fyi, I have been updating the styling in the redux-form/redux-form-website-template as well, but wanted to wait to finish the updates before creating that PR. 👍
Related PRs:
Styling updates for site bundles and future versions: Redux-Form-Website-Template Update
Minor Update to Version Checker: Redux-Form-Doc-Version-Checker
A few questions regarding updates on my end: