Skip to content

[v/25.2] manage/k8s: document decommission timing (--decommission-wait-interval)#1765

Open
david-yu wants to merge 1 commit into
v/25.2from
dyu/decommission-timing-v25.2
Open

[v/25.2] manage/k8s: document decommission timing (--decommission-wait-interval)#1765
david-yu wants to merge 1 commit into
v/25.2from
dyu/decommission-timing-v25.2

Conversation

@david-yu

Copy link
Copy Markdown
Contributor

Backport of #1761 to v/25.2. Supersedes #1764 (closed) — recreated on a fresh branch so the Netlify preview builds from a clean dependency cache (the old branch's preview cache was poisoned by the recent Netlify build-image upgrade and kept failing npm install even after the node pin).

Content

Adds the "Tune automatic decommission timing" section to the Kubernetes decommission page: --decommission-wait-interval (Operator, via additionalCmdFlags), decommissionRequeueTimeout / decommissionAfter (Helm sidecar), a TIP cross-reference, and shell-correct --set "additionalCmdFlags={...}" quoting.

The main-only Operator-example rewrite from #1761 (the "do not add sideCars.brokerDecommissioner here" paragraph + <1> callout) is intentionally omitted: v/25.2's Operator example uses the version-appropriate brokerDecommissioner sidecar.

Also includes a build fix

netlify.toml is added pinning NODE_VERSION = "20" (matching .github/workflows/test-docs.yml). Without it, the new Netlify image defaults to node 22 / npm 10.9.3, which fails npm install on this branch's deps. This mirrors the fix already merged-ready on the v/25.3 backport (#1763).

🤖 Generated with Claude Code

@netlify

netlify Bot commented Jun 24, 2026

Copy link
Copy Markdown

Deploy Preview for redpanda-docs-preview failed. Why did it fail? →

Name Link
🔨 Latest commit 83256e7
🔍 Latest deploy log https://app.netlify.com/projects/redpanda-docs-preview/deploys/6a3cadadaa5f9d00086dbb69

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 40f221f1-55cf-476c-9f5d-21f1b62b214f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dyu/decommission-timing-v25.2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Feediver1

Copy link
Copy Markdown
Contributor

@david-yu — found why your v/25.2 PRs (#1765, #1767) won't build, and it's not your content.

v/25.2's playbook was left pointing at the old ROOT component after the ROOT → streaming rename (#1703) updated antora.yml but not local-antora-playbook.yml. The start_page aims at a component that no longer exists, so Antora can't resolve the site start page and the Netlify deploy fails. This has broken every v/25.2 deploy since late May — later PRs just merged anyway because the preview isn't a required check. That's the "something funny with 25.2" you hit.

Fix is up: #1768 (3-line playbook patch on v/25.2).

Once #1768 merges, please rebase #1765 and #1767 on the updated v/25.2 (or re-trigger the deploy) so the previews pick up the corrected playbook. One more thing when you do: don't trust a green Netlify SUCCESS — grep the deploy log for ERROR (asciidoctor). v/25.2 has a backlog of merged-but-never-cleanly-built PRs, so once the start page resolves, other pre-existing build errors may surface that were hidden behind the fatal failure. Anything sourced from your branch/files is yours; anything else is pre-existing.

…l) [v/25.2 backport]

Backport of #1761 to v/25.2. Adds the "Tune automatic decommission timing"
section: --decommission-wait-interval (Operator, via additionalCmdFlags),
decommissionRequeueTimeout / decommissionAfter (Helm sidecar), a TIP
cross-reference, and shell-correct --set "additionalCmdFlags={...}" quoting.
Omits the main-only Operator-example rewrite, since v/25.2's example uses the
version-appropriate brokerDecommissioner sidecar.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@david-yu david-yu force-pushed the dyu/decommission-timing-v25.2 branch from 0f21f81 to 83256e7 Compare June 25, 2026 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants