Apply policies for normal and pipeline mode #3818
Open
+378
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o vv-apply-policies
Base automatically changed from
vv-implement-policies
to
feat/request-response-policies
October 27, 2025 12:34
…is-py into vv-apply-policies
| Returns a list of nodes for commands with a special policy. | ||
| """ | ||
| if not self._aggregate_nodes: | ||
| raise RedisClusterException('Cannot execute FT.CURSOR commands without FT.AGGREGATE') |
There was a problem hiding this comment.
I guess this exception reports relation with FT.CURSOR and FT.AGGREGATE, because the Special policy is related just to those two, but if this type of policy is extended to cover additional commands, this error message might become confusing.
There was a problem hiding this comment.
For special cases we would anyway need something like separate mapping or strategies for each special command when they would appear. But for now, we don't know if there will be any soon, so I didn't implement it
petyaslavova
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.