fix(client): make unstable cmds throw #2990
Merged
+72
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the docs, unstableResp3 commands should throw
when client is created with { RESP: 3, unstableResp3: false|undefined }
fixes redis#2989
nkaradzhov
requested review from
bobymicroby,
elena-kolevska,
PavelPashov and
htemelski-redis
bobymicroby
reviewed
Jun 5, 2025
| @@ -38,7 +38,11 @@ export function attachConfig< | |||
| Class: any = class extends BaseClass {}; | |||
|
|
|||
| for (const [name, command] of Object.entries(commands)) { | |||
| Class.prototype[name] = createCommand(command, RESP); | |||
| if (config?.RESP == 3 && command.unstableResp3 && !config.unstableResp3) { | |||
There was a problem hiding this comment.
@nkaradzhov I just remembered that I saw this piece of code which was supposed to attach a command that throws an error. Maybe we can fix that code instead.
There was a problem hiding this comment.
@bobymicroby this is working properly. The problem is that it is executed only for module commands. And we have XREAD and XREADGROUP as part of the main client. So we should add the same logic in the place we attach the core functions as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the docs, unstableResp3 commands should throw when client is created with { RESP: 3, unstableResp3: false|undefined }
fixes #2989
Checklist
npm testpass with this change (including linting)?