Require explicit config to use io_uring transport #3234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3222
This mitigates the impact of the breaking change introduced version 6.1.0 that prefers the io_uring transport over epoll. Due to this change, some users may be inadvertently using io_uring when they intend to use epoll. Since other users are now expecting the new default of io_uring, the safest option is to require explicit configuration whenever both transports are available.
While this is also breaking change, it breaks in an obvious way by throwing an exception if the transport is not configured. io_uring support is also experimental, so breaking changes are allowed, and users should expect to have to resolve this sort of issue when they upgrade.