Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV: add new vector set data type and command pages #1334

Merged
merged 10 commits into from
Apr 3, 2025
Merged

DEV: add new vector set data type and command pages #1334

merged 10 commits into from
Apr 3, 2025
+1,417 −2

Conversation

dwdougherty
Copy link
Collaborator

@dwdougherty dwdougherty commented Mar 28, 2025 •
edited
Loading

@dwdougherty
Initial commit of vector set docs
Loading
Loading status checks…
6b692b9
@dwdougherty
Add'l commit of vector set docs
Loading
Loading status checks…
54181c6
@dwdougherty
Add'l commit of vector set docs
Loading
Loading status checks…
5eddbf4
@dwdougherty
Adding data type and command pages
Loading
Loading status checks…
c91a8e6
@dwdougherty
Added RESP2 and RESP3 return information
Loading
Loading status checks…
838fd6e
@dwdougherty dwdougherty added the CE 8.0 Redis Community Edition 8.0 (future) label Mar 28, 2025
@dwdougherty dwdougherty requested review from K-Jo, LiorKogan and a team March 28, 2025 17:49
@dwdougherty dwdougherty self-assigned this Mar 28, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 28, 2025 •
edited
Loading

Staging links:
https://redis.io/docs/staging/DOC-4988/commands/vadd/
https://redis.io/docs/staging/DOC-4988/commands/vcard/
https://redis.io/docs/staging/DOC-4988/commands/vdim/
https://redis.io/docs/staging/DOC-4988/commands/vemb/
https://redis.io/docs/staging/DOC-4988/commands/vgetattr/
https://redis.io/docs/staging/DOC-4988/commands/vinfo/
https://redis.io/docs/staging/DOC-4988/commands/vlinks/
https://redis.io/docs/staging/DOC-4988/commands/vrandmember/
https://redis.io/docs/staging/DOC-4988/commands/vrem/
https://redis.io/docs/staging/DOC-4988/commands/vsetattr/
https://redis.io/docs/staging/DOC-4988/commands/vsim/
https://redis.io/docs/staging/DOC-4988/develop/data-types/vector-sets/
https://redis.io/docs/staging/DOC-4988/develop/data-types/vector-sets/filtered-search
https://redis.io/docs/staging/DOC-4988/develop/data-types/vector-sets/memory
https://redis.io/docs/staging/DOC-4988/develop/data-types/vector-sets/performance
https://redis.io/docs/staging/DOC-4988/develop/data-types/vector-sets/scalability
https://redis.io/docs/staging/DOC-4988/develop/data-types/vector-sets/troubleshooting
https://redis.io/docs/staging/DOC-4988/operate/oss_and_stack/install/archive/

@dwdougherty dwdougherty changed the base branch from main to community-edition-8 March 28, 2025 17:49
dwdougherty and others added 2 commits March 28, 2025 14:38
@dwdougherty
Fix some atrocious grammar on the vs index page.
Loading
Loading status checks…
4830c8b
@dwdougherty
A few more quick fixes

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
3323add
mich-elle-luna
mich-elle-luna approved these changes Mar 29, 2025
View reviewed changes
Copy link
Collaborator

@mich-elle-luna mich-elle-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! just a few editorial nits

dwdougherty and others added 2 commits March 31, 2025 06:28
@dwdougherty @mich-elle-luna
Apply suggestions from code review

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
af23780 
Co-authored-by: mich-elle-luna <[email protected]>
@dwdougherty @mich-elle-luna
Apply review comments

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
97a49a5 
Co-authored-by: mich-elle-luna <[email protected]>
@dwdougherty
Copy link
Collaborator Author

Thanks for the review, @mich-elle-luna!

@dwdougherty dwdougherty removed the request for review from LiorKogan March 31, 2025 14:21
@mich-elle-luna
Copy link
Collaborator

mich-elle-luna commented Apr 2, 2025 •
edited
Loading

Hi David, this will be a preview data type, can we add the word preview to these docs?

@dwdougherty
Apply preview banner + misc. fixes
Loading
Loading status checks…
8546017
@dwdougherty
Copy link
Collaborator Author

@mich-elle-luna : I added a banner. Will this work?

@mich-elle-luna
Copy link
Collaborator

that works, thank you!

@dwdougherty dwdougherty merged commit 22beaaa into community-edition-8 Apr 3, 2025
5 checks passed
@dwdougherty dwdougherty deleted the DOC-4988 branch April 3, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mich-elle-luna mich-elle-luna

@K-Jo K-Jo

Assignees

@dwdougherty dwdougherty

Labels
CE 8.0 Redis Community Edition 8.0 (future)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dwdougherty @mich-elle-luna