DOC-4996 hiredis docs #1332
Merged
DOC-4996 hiredis docs #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwdougherty
approved these changes
Mar 28, 2025
There was a problem hiding this comment.
Very nice, @andy-stark-redis! Apart from one non-blocking comment, LGTM.
Comment on lines
+13
to
+14
| linkTitle: hiredis (C) | ||
| title: hiredis guide (C) |
There was a problem hiding this comment.
It's not clear to me how hiredis is to be capitalized. The GitHub page uses "Hiredis"; but some blogs use either "HIREDIS" or "hiredis". It's not a showstopper by any means; just me being overly pedantic.
There was a problem hiding this comment.
Yeah, tbh, I just picked one and tried to stick with it :-) I'll be happy to change it if anyone has a definitive version of the name.
|
Thanks for the review @dwdougherty ! |
uglide
reviewed
Mar 28, 2025
Co-authored-by: Igor Malinovskiy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOC-4996
Note: there is more to add to the
hiredisdocs, but I thought I'd get some feedback on this basic set. The C code is all tested but I'd be more than happy to hear suggestions for good/idiomatic C practice.