-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-4989 added node-js AMR page #1306
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Language LGTM. I did not validate the technical details. Just one question about a possibly superfluous asterisk (cheeky bugger). :)
|
||
### Auth code flow with PKCE | ||
|
||
*Auth code flow with Proof Key for Code Exchange (PKCE)* lets a client app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the asterisk a typo, or a marker for a footnote (no such footnote exists; at least, not that I could find)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's italic formatting (line also starts with *). Warms my heart to see an American say "bugger", though :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh dear, my bad. I didn't catch the asterisk at the beginning. Next time: consume caffeine before reviewing PRs!
DOC-4989
I've worked from the repo README file and also incorporated some stuff from the other clients' AMR pages. Any suggestions or corrections are most welcome :-)