Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-4989 added node-js AMR page #1306

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andy-stark-redis
Copy link
Contributor

@andy-stark-redis andy-stark-redis commented Mar 21, 2025

DOC-4989

I've worked from the repo README file and also incorporated some stuff from the other clients' AMR pages. Any suggestions or corrections are most welcome :-)

@andy-stark-redis andy-stark-redis self-assigned this Mar 21, 2025
Copy link
Contributor

@andy-stark-redis andy-stark-redis requested a review from a team March 21, 2025 12:00
Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Language LGTM. I did not validate the technical details. Just one question about a possibly superfluous asterisk (cheeky bugger). :)


### Auth code flow with PKCE

*Auth code flow with Proof Key for Code Exchange (PKCE)* lets a client app
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the asterisk a typo, or a marker for a footnote (no such footnote exists; at least, not that I could find)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's italic formatting (line also starts with *). Warms my heart to see an American say "bugger", though :-)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh dear, my bad. I didn't catch the asterisk at the beginning. Next time: consume caffeine before reviewing PRs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants