Skip to content

Conversation

pd-redis
Copy link
Collaborator

@pd-redis pd-redis commented Jul 25, 2025

Before:
image

After:
image

Copy link
Contributor

github-actions bot commented Jul 25, 2025

Code Coverage - Integration Tests

Status Category Percentage Covered / Total
🟢 Statements 81.71% 16211/19839
🟡 Branches 64.78% 7307/11279
🟡 Functions 70.77% 2279/3220
🟢 Lines 81.35% 15249/18744

Copy link
Contributor

github-actions bot commented Jul 25, 2025

Code Coverage - Frontend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 81.45% 18868/23166
🟡 Branches 66.92% 8258/12341
🟡 Functions 75.2% 4928/6553
🟢 Lines 81.86% 18467/22560

Test suite run success

4832 tests passing in 633 suites.

Report generated by 🧪jest coverage report action from 2491818

@KIvanow
Copy link
Contributor

KIvanow commented Jul 25, 2025

Couple of questions:
1 - Why are the styles done through sass, instead of Styled components to keep in line with the current Redis UI version and approach?
2 - not related to this PR, but is reduced spacing between the icon and label in the tabs by design?

@pd-redis
Copy link
Collaborator Author

Couple of questions: 1 - Why are the styles done through sass, instead of Styled components to keep in line with the current Redis UI version and approach? 2 - not related to this PR, but is reduced spacing between the icon and label in the tabs by design?

  1. Because it was the fastest way to do it. I have not seen actual design for the "File picker" component, so the simplest was to reuse existing styles
  2. Can't say, the tabs are not part of this PR, maybe something to put the list to tighten for the UI?

KIvanow
KIvanow previously approved these changes Jul 28, 2025
Copy link
Contributor

github-actions bot commented Jul 28, 2025

Code Coverage - Backend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 92.34% 13773/14916
🟡 Branches 74% 4144/5600
🟢 Functions 85.85% 2123/2473
🟢 Lines 92.13% 13166/14291

Test suite run success

2940 tests passing in 286 suites.

Report generated by 🧪jest coverage report action from 2491818

Comment on lines +60 to 62
.RI-File-Picker__showDrop .RI-File-Picker__prompt, .RI-File-Picker__input:focus + .RI-File-Picker__prompt {
background-color: var(--euiColorEmptyShade);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these styled used? Or just euiFilePicker* class was replaced with RI-File-Picker*?

@pd-redis pd-redis merged commit 1ccfce9 into fe/feature/RI-7039-replace-eui Jul 29, 2025
32 checks passed
@pd-redis pd-redis deleted the feature/fe/RI-7210-replace-eui-file-picker branch July 29, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants