RI-6570 Verify generic edit operations in the browsers module #4730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valkirilov
requested review from
KrumTy,
pawelangelow,
dantovska,
ArtemHoruzhenko,
pd-redis and
KIvanow
as code owners
Code Coverage - Backend unit tests
Test suite run success2941 tests passing in 286 suites. Report generated by 🧪jest coverage report action from 6f85828 |
Code Coverage - Frontend unit tests
Test suite run success4792 tests passing in 628 suites. Report generated by 🧪jest coverage report action from 6f85828 |
pawelangelow
deleted the
feature/RI-6570/e2e-playwright-browser-keys-edit
branch
pawelangelow
restored the
feature/RI-6570/e2e-playwright-browser-keys-edit
branch
valkirilov
force-pushed
the
feature/RI-6570/e2e-playwright-browser-keys-read
branch
from
76052ac to
bc2fd09
Compare
Base automatically changed from
feature/RI-6570/e2e-playwright-browser-keys-read
to
main
July 25, 2025 08:39
valkirilov
force-pushed
the
feature/RI-6570/e2e-playwright-browser-keys-edit
branch
from
6f85828 to
4790919
Compare
pawelangelow
previously approved these changes
Jul 25, 2025
* added e2e test to verify whether the edit key name functionality is working fine in the browser module * also verify the ttl field and jow it can be updated or cleared re #RI-6570
valkirilov
force-pushed
the
feature/RI-6570/e2e-playwright-browser-keys-edit
branch
from
4790919 to
233cf46
Compare
pawelangelow
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new E2E tests to check the generic update functionalities in the Browsers module. These tests make sure that when you click on a key, you can update its name and TTL.
How the tests work
Note: Once PR: 4723 is merged, make sure to update the target branch of this pull request to lead to feature/RI-6570/PlayWright branch.
Code Changes
How to run the tests
You can always refer to the README, but simply running the following command should do the trick for you
Edit (generic)