Skip to content

Docs and Web: Add to the master branch and build with each push #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

zacikpa
Copy link
Contributor

@zacikpa zacikpa commented Apr 7, 2025

In this PR, I propose to move the webpage files from the gh-pages to the master branch. The webpage (preview at https://zacikpa.github.io/tuned/) now contains a link to the documentation (preview at https://zacikpa.github.io/tuned/docs/manual.html), which would be automatically deployed with each push to master.

The documentation of plug-ins and built-in functions is built from code docstrings.

The PR contains some additional refactoring of TuneD built-in functions, see the individual commits.

@zacikpa zacikpa requested a review from yarda April 7, 2025 18:16
@zacikpa
Copy link
Contributor Author

zacikpa commented Apr 7, 2025

@yarda, technically, the static webpage files could be kept in the gh-pages branch, but the workflow itself should be in master. Let me know what you think is appropriate. Personally, I would prefer to have everything in master and get rid of the large files (i.e., fonts).

@zacikpa zacikpa force-pushed the doc-build branch 5 times, most recently from 85e4c16 to 65c5e73 Compare April 8, 2025 08:59
@zacikpa
Copy link
Contributor Author

zacikpa commented Apr 8, 2025

I changed my opinion: it is probably neater to keep the static files in gh-pages. I updated this PR to pull the files from there when building the website.

I also opened #765 which should be merged alongside this PR. When the PRs are merged, the repository also needs a manual update of the settings to make it build the website using the workflow.

zacikpa added 10 commits May 9, 2025 10:45
Read the docstrings using ASTs instead of
importing the modules; this prevents the
need to install TuneD dependencies when
just building the docs (e.g., in Github Pages).
The docs are now asciidoc with examples,
ready to be included into the manual.
This is the standard in Python and it prevents
the issue of using reserved/existing names, e.g.,
in the case of the `exec` or `log` function.
Prevents redundancy. The same thing is already
done for plugins.
The manual is now built automatically with each
push to the master branch.
- remove duplicate sections
- move profile syntax description to the second module
- move mention of profile merging after list of profiles
@zacikpa
Copy link
Contributor Author

zacikpa commented May 30, 2025

I did some minor changes to the docs themselves, e.g., updates from yum to dnf. I also noticed that downstream RHEL docs diverged considerably from these - I don't think it's a blocker for merging this, but we should likely discuss the future of these upstream docs. I'd be personally inclined towards making them distinct from the RHEL docs and generating as much doc content as possible from the source code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant