Fix thinkpad_function_keys feature #755
Conversation
The thinkpad_function_keys feature really doesn't have anything to do with Thinkpad function keys. It is just monitoring for sysfs events from firmware/acpi/platform_profile Rename the feature to be more accurate. It is useful to other platforms than Thinkpads :) Signed-off-by: Mark Pearson <[email protected]>
|
Thanks, @mrhpearson. While I agree that the original name was poorly chosen, some users are already using it (see #710), so we should at least make the old name an alias of the new one. |
|
Hi @zacikpa Good point - though I'd argue that as the 2nd commit enables the feature by default the user won't see any impact will they? The feature will continue working for them correctly. Happy to change the commits if needed, just not sure if it's actually necessary. Let me know if I'm missing something. Thanks for the review! |
|
The problem is that the configuration file is defined as "noreplace" in the spec file, and thus it won't be replaced if the user has already made changes to it. I believe it works similarly in other distros. |
|
Right - is that a problem? You have a config file with an extra useless line in it is all. I don't want to make more of this than is needed, so I'm happy to remove the naming change if that's preferred, and just enable the feature by default. Just figured it was a good opportunity to make it a bit more accurate. I'll get that ready but just wanted to be sure it was really required. |
|
Thanks! If you could just squash (fixup) the last change into the second commit, that would be perfect. |
If the platform profile is changed outside of tuned then the update does not get reflected in tuned-adm and gnome-settings. This is particularly noticeable on Thinkpads where the F8 Mode key changes the profile but the change is not reflected. It can also be demonstrated by changing the profile from the command line. Enable the feature by default. It works well and is useful. Tested on multiple Thinkpads, but I expect it to be useful to other vendor platforms too. Signed-off-by: Mark Pearson <[email protected]>
mrhpearson
force-pushed
the
fix_thinkpad_fn_keys
branch
from
b3aa029 to
bd5f285
Compare
The thinkpad_function_keys feature is incorrectly named, so rename it to sysfs_acpi_monitor to be more correct.
It is also a useful feature - if profiles are updated on Fedora 41 outside of tuned, then they are not reflected in tuned or gnome-settings (or likely KDE, though I didn't test that). Enable the feature by default.
Tested on multiple devices. As a note - I expect this feature to be useful to any vendor supporting platform profiles, not just Thinkpads (though it does mean our function keys work correctly again which is nice)
Thanks
Mark