profiles: use med_power_with_dipm for SATA ALPM
#745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of `min_power` can lead to data corruption[1] and has been replaced in the documentation, and an example using `medium_power` was updated to use `med_power_with_dipm` (the kernel default[2] with better better power savings than `medium_power`). [1] https://hansdegoede.livejournal.com/18412.html [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/ata/Kconfig?id=5433f0e7427ae4f5b128d89ec16ccaafc9fef5ee Signed-off-by: Ibrahim Ansari <[email protected]>
Using `min_power` can lead to data loss, and `med_power_with_dipm` delivers similar power savings without the chance of data loss. [1] `med_power_with_dipm` is the default setting[2] in upstream Linux for SATA Link Power Management, and should provide significant power savings on laptops using SATA drives over `medium_power`. [1] https://hansdegoede.livejournal.com/18412.html [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/ata/Kconfig?id=5433f0e7427ae4f5b128d89ec16ccaafc9fef5ee Signed-off-by: Ibrahim Ansari <[email protected]>
|
Thanks LGTM. I tested it with the RHEL-8 kernel (probably the oldest supported configuration) and it's supported there, so we don't need to add fallback mechanism (like e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
min_powercan lead to data loss, andmed_power_with_dipmdelivers similar power savings without the chance of data loss. [1]
med_power_with_dipmis the default setting[2] in upstream Linux forSATA Link Power Management, and should provide significant power
savings on laptops using SATA drives over
medium_power.[1] https://hansdegoede.livejournal.com/18412.html
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/ata/Kconfig?id=5433f0e7427ae4f5b128d89ec16ccaafc9fef5ee
Note: Testing on a SATA system would be appreciated to confirm this patch is setting
med_power_with_dipmas expected, since unfortunately I'm not sure when I'll be able to get back to my desktop at home