Skip to content

Recommendation to use second level heading syntax for assembly-level prerequisites #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Preeticp
Copy link
Contributor

This issue fixes #124 as per discussions with the team and as per comments on the issue.

@Preeticp Preeticp requested a review from sterobin September 30, 2020 11:36
@Preeticp
Copy link
Contributor Author

Preeticp commented Sep 30, 2020

@redhat-documentation/fcc-review-board @rkratky @sterobin @emmurphy1 @theashiot @kalexand-rh can you all please review this PR. Thank you!

Copy link
Contributor

@sterobin sterobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Preeticp Good with me for the reasons we've discussed on the call, though I got the sense that we still don't have a majority agreement yet. Will see if we can get enough approvals here. Thanks for this!

@oraNod oraNod self-requested a review September 30, 2020 15:48
Copy link
Contributor

@oraNod oraNod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Preeticp good suggestion IMO

Copy link
Contributor

@kalexand-rh kalexand-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Preeticp Preeticp merged commit 038448a into redhat-documentation:master Oct 19, 2020
msuchane added a commit to redhat-documentation/newdoc that referenced this pull request Oct 19, 2020
@msuchane
Copy link

I've updated the assembly template in newdoc to match this change. Commit: redhat-documentation/newdoc@9e27182

The updated template is available in newdoc version 2.6.1, which I'm now releasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with the assembly-level prerequisites heading
9 participants