Skip to content

The method finalize() from the type Object is deprecated since version 9 #889

Closed

Description

@sallyur
Environment
  • Operating System: Win & Mac
  • JDK version: 12
  • Visual Studio Code version: 1.33.1
  • Java extension version: 0.43.0
Steps To Reproduce
  1. Open one java project
  2. Run the command "Source action" ->Override/Implement Methods… ==> finalize()
Current Result

Warning in probelm window, we provide this method but tell the user that it is deprecated
image

Expected Result

We shouldn't provide a deprecated method to user

Activity

  1. fbricon commented on Apr 17, 2019

    @fbricon
    Collaborator

    We shouldn't prevent a user from overriding a deprecated method. BTW, finalize is not selected by default when you select the methods to override.
    Ideally though, the deprecated method should appear with a different style (strikethrough?), which would require sending extra information at the protocol level. Unfortunately, it's not possible for VS Code to apply specific styles to specific item entries in this quick pick list.

  2. fbricon commented on Apr 17, 2019

    @fbricon
    Collaborator

    BTW, I tried setting QuickPickItem.alwaysShow to false, but it seems it has no effect on window.showQuickPick, item is still being shown. @chrmarti are there any real-life example of QuickPickItem.alwaysShow usages out there? What's the expected behavior?

  3. chrmarti commented on Apr 18, 2019

    @chrmarti

    @fbricon QuickPickItem.alwaysShow is false by default. You would set that to true to keep it in the list even when it doesn't match the user's typed filter.

  4. fbricon commented on Apr 18, 2019

    @fbricon
    Collaborator

    @chmarti thanks for the explanation. I feel dumb for even asking :-)

  5. robstryker commented on Oct 29, 2026

    @robstryker
    Contributor

    Closing this issue. As @fbricon said, we don't have a way to set style to quick pick entries. Not planned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions