Skip to content

fix(fab): remove fab plugin completely#4920

Open
ciiay wants to merge 2 commits into
redhat-developer:mainfrom
ciiay:rhidp-13680-remove-fab-plugin-2
Open

fix(fab): remove fab plugin completely#4920
ciiay wants to merge 2 commits into
redhat-developer:mainfrom
ciiay:rhidp-13680-remove-fab-plugin-2

Conversation

@ciiay

@ciiay ciiay commented Jun 4, 2026

Copy link
Copy Markdown
Member

Description

For RHIDP-13680

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci openshift-ci Bot requested review from PatAKnight and psrna June 4, 2026 15:47
@ciiay ciiay force-pushed the rhidp-13680-remove-fab-plugin-2 branch from b61d2c4 to 3bbff91 Compare June 4, 2026 15:53
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

The container image build workflow finished with status: cancelled.

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

The container image build workflow finished with status: cancelled.

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

@codecov

codecov Bot commented Jun 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.82%. Comparing base (1c0f25c) to head (8775d44).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4920   +/-   ##
=======================================
  Coverage   55.82%   55.82%           
=======================================
  Files         121      121           
  Lines        2350     2350           
  Branches      563      562    -1     
=======================================
  Hits         1312     1312           
  Misses       1032     1032           
  Partials        6        6
Flag Coverage Δ
rhdh 55.82% <ø> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c0f25c...8775d44. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ciiay

ciiay commented Jun 4, 2026

Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm

@ciiay

ciiay commented Jun 4, 2026

Copy link
Copy Markdown
Member Author

/retest

1 similar comment
@ciiay

ciiay commented Jun 4, 2026

Copy link
Copy Markdown
Member Author

/retest

@ciiay

ciiay commented Jun 4, 2026

Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm

1 similar comment
@ciiay

ciiay commented Jun 4, 2026

Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm

@ciiay

ciiay commented Jun 5, 2026

Copy link
Copy Markdown
Member Author

/retest

3 similar comments
@ciiay

ciiay commented Jun 5, 2026

Copy link
Copy Markdown
Member Author

/retest

@ciiay

ciiay commented Jun 5, 2026

Copy link
Copy Markdown
Member Author

/retest

@ciiay

ciiay commented Jun 8, 2026

Copy link
Copy Markdown
Member Author

/retest

@ciiay

ciiay commented Jun 8, 2026

Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm

@its-mitesh-kumar

its-mitesh-kumar commented Jun 9, 2026

Copy link
Copy Markdown
Member

/retest

1 similar comment
@ciiay

ciiay commented Jun 9, 2026

Copy link
Copy Markdown
Member Author

/retest

@ciiay ciiay mentioned this pull request Jun 12, 2026
Closed
5 tasks
@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

@ciiay

ciiay commented Jun 15, 2026

Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm

1 similar comment
@debsmita1

debsmita1 commented Jun 15, 2026

Copy link
Copy Markdown
Member

/test e2e-ocp-helm

@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

@ciiay

ciiay commented Jun 15, 2026

Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm

1 similar comment
@ciiay

ciiay commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm

@debsmita1

debsmita1 commented Jun 16, 2026

Copy link
Copy Markdown
Member

/retest

1 similar comment
@ciiay

ciiay commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

/retest

HusneShabbir
HusneShabbir reviewed Jun 17, 2026
View reviewed changes

@HusneShabbir HusneShabbir left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @teknaS47

@jrichter1

jrichter1 commented Jun 17, 2026

Copy link
Copy Markdown
Member

can you try rebasing first?

christoph-jerolimov
christoph-jerolimov approved these changes Jun 17, 2026
View reviewed changes

@christoph-jerolimov christoph-jerolimov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest

@openshift-ci openshift-ci Bot added the lgtm label Jun 17, 2026
@christoph-jerolimov christoph-jerolimov force-pushed the rhidp-13680-remove-fab-plugin-2 branch from cd2a371 to e75ffc5 Compare June 17, 2026 10:39
@openshift-ci openshift-ci Bot removed the lgtm label Jun 17, 2026
@christoph-jerolimov

christoph-jerolimov commented Jun 17, 2026

Copy link
Copy Markdown
Member

pushed the rebase button

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Jun 17, 2026
@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

@christoph-jerolimov

christoph-jerolimov commented Jun 17, 2026

Copy link
Copy Markdown
Member

/retest

@gustavolira

gustavolira commented Jun 17, 2026

Copy link
Copy Markdown
Member

/test e2e-ocp-helm

1 similar comment
@gustavolira

gustavolira commented Jun 17, 2026

Copy link
Copy Markdown
Member

/test e2e-ocp-helm

@ciiay ciiay force-pushed the rhidp-13680-remove-fab-plugin-2 branch from e75ffc5 to cfcf5f8 Compare June 18, 2026 16:00
@openshift-ci openshift-ci Bot removed the lgtm label Jun 18, 2026
@openshift-ci

openshift-ci Bot commented Jun 18, 2026

Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

@ciiay

ciiay commented Jun 19, 2026

Copy link
Copy Markdown
Member Author

/retest

1 similar comment
@ciiay

ciiay commented Jun 23, 2026

Copy link
Copy Markdown
Member Author

/retest

ciiay added 2 commits June 22, 2026 23:33
@ciiay
fix(fab): remove fab plugin completely
8b3d885 
Signed-off-by: Yi Cai <yicai@redhat.com>
@ciiay
removed fab localization
8775d44 
Signed-off-by: Yi Cai <yicai@redhat.com>
@ciiay ciiay force-pushed the rhidp-13680-remove-fab-plugin-2 branch from cfcf5f8 to 8775d44 Compare June 23, 2026 03:35
@sonarqubecloud

sonarqubecloud Bot commented Jun 23, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christoph-jerolimov christoph-jerolimov christoph-jerolimov approved these changes

@PatAKnight PatAKnight Awaiting requested review from PatAKnight

@psrna psrna Awaiting requested review from psrna

+1 more reviewer

@HusneShabbir HusneShabbir HusneShabbir left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@christoph-jerolimov christoph-jerolimov

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ciiay @its-mitesh-kumar @debsmita1 @jrichter1 @christoph-jerolimov @gustavolira @HusneShabbir