Skip to content

feat: support autologout config #3643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JessicaJHee wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: support autologout config #3643

JessicaJHee wants to merge 1 commit into from
+77 −1

Conversation

@JessicaJHee
Copy link
Member

@JessicaJHee JessicaJHee commented Oct 29, 2025 •
edited
Loading

Description

Please explain the changes you made here.
Enables autoLogout in RHDH

  • Disabled by default
  • Default idleTimeoutMinutes in RHDH is set to 60 minutes

E2E tests are also included in the PR under the auth provider tests

  • tests passed locally
image

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Enable this feature in the app-config and verify in the UI after 30 seconds that the pop-up appears
image

auth:
  autologout:
    enabled: true
    idleTimeoutMinutes: 0.5

@openshift-ci openshift-ci bot requested review from nickboldt and rm3l October 29, 2025 15:36
@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

The image is available at:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

The image is available at:

@redhat-developer redhat-developer deleted a comment from openshift-ci bot Nov 7, 2025
@JessicaJHee
Copy link
Member Author

JessicaJHee commented Nov 7, 2025

/test e2e-ocp-operator-auth-providers-nightly

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

The image is available at:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2025

The image is available at:

@JessicaJHee
Copy link
Member Author

JessicaJHee commented Nov 10, 2025

/test e2e-ocp-operator-auth-providers-nightly

@JessicaJHee
Copy link
Member Author

JessicaJHee commented Nov 12, 2025

/test e2e-ocp-operator-auth-providers-nightly

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025

The image is available at:

@JessicaJHee
Copy link
Member Author

JessicaJHee commented Nov 12, 2025

/test e2e-ocp-operator-auth-providers-nightly

@JessicaJHee
Copy link
Member Author

JessicaJHee commented Nov 12, 2025

/retest

@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025

The image is available at:

@JessicaJHee
Copy link
Member Author

JessicaJHee commented Nov 12, 2025

/retest

@JessicaJHee
Copy link
Member Author

JessicaJHee commented Nov 13, 2025

/test e2e-ocp-operator-auth-providers-nightly

@JessicaJHee
Copy link
Member Author

JessicaJHee commented Nov 26, 2025

/test e2e-ocp-operator-auth-providers-nightly

@rhdh-qodo-merge
Copy link

rhdh-qodo-merge bot commented Nov 26, 2025

You are above your monthly Qodo Merge usage quota. If you are a paying user, please link your GitHub/GitLab/Bitbucket account with your qodo account here to claim your seat. To allow usage organization-wide without linking, please reach to Qodo.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2025

The image is available at:

@JessicaJHee
Copy link
Member Author

JessicaJHee commented Nov 27, 2025

/test e2e-ocp-operator-auth-providers-nightly

@rhdh-qodo-merge
Copy link

rhdh-qodo-merge bot commented Nov 27, 2025

You are above your monthly Qodo Merge usage quota. If you are a paying user, please link your GitHub/GitLab/Bitbucket account with your qodo account here to claim your seat. To allow usage organization-wide without linking, please reach to Qodo.

@JessicaJHee
Copy link
Member Author

JessicaJHee commented Nov 27, 2025

This error was causing the pop-up to be blocked in OpenShift deployments (causing auth e2e test failures):

index.esm.js:1 Creating a worker from 'blob:<rhdh-url>' violates the following Content Security Policy directive: "worker-src 'self'". The action has been blocked.

There are 2 ways to solve this issue:

  1. Setting useWorkerTimers: false
  • The timer may not be 100% accurate if the tab is in the background and the timer "drifts"
  1. Adding this to app-config
    backend:
      csp:
        worker-src:
          - "'self'"
          - "blob:"

Allowing blob: URLs is not safe and has security implications for enterprise customers. It's better to set useWorkerTimers: false by default and let customers configure the CSP themselves if they need precise timeouts.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025

The image is available at:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2025

The image is available at:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2025

The image is available at:

@JessicaJHee
Copy link
Member Author

JessicaJHee commented Nov 28, 2025

/test e2e-ocp-operator-auth-providers-nightly

@rhdh-qodo-merge
Copy link

rhdh-qodo-merge bot commented Nov 28, 2025

You are above your monthly Qodo Merge usage quota. If you are a paying user, please link your GitHub/GitLab/Bitbucket account with your qodo account here to claim your seat. To allow usage organization-wide without linking, please reach to Qodo.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

The image is available at:

@JessicaJHee
Copy link
Member Author

JessicaJHee commented Dec 1, 2025

/test e2e-ocp-operator-auth-providers-nightly

1 similar comment
@JessicaJHee
Copy link
Member Author

JessicaJHee commented Dec 2, 2025

/test e2e-ocp-operator-auth-providers-nightly

@openshift-ci
Copy link

openshift-ci bot commented Dec 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign polasudo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@JessicaJHee
Copy link
Member Author

JessicaJHee commented Dec 5, 2025

/test e2e-ocp-operator-auth-providers-nightly

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

The image is available at:

@openshift-ci
Copy link

openshift-ci bot commented Dec 5, 2025

@JessicaJHee: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-helm c692274 link true /test e2e-ocp-helm
ci/prow/e2e-ocp-operator-auth-providers-nightly c692274 link false /test e2e-ocp-operator-auth-providers-nightly

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickboldt nickboldt Awaiting requested review from nickboldt

@rm3l rm3l Awaiting requested review from rm3l

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JessicaJHee @albarbaro