-
Notifications
You must be signed in to change notification settings - Fork 211
fix(sidebar): make left sidebar scrollbar visible on hover and keep "administration" & "settings" sticky at the bottom #3255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sidebar): make left sidebar scrollbar visible on hover and keep "administration" & "settings" sticky at the bottom #3255
Conversation
|
/retest-required |
|
/retest |
|
/retest-required |
|
I think as soon as user hover on sidebar scrollbar should be visible. But currently only when user start scrolling then only scrollbar is visible. @ShiranHi @Lucifergene WDYT ? Scroll.mov |
|
Yeah, makes sense. Thanks @its-mitesh-kumar :) |
I agree, the scrollbar should be visible on hover. Thank you. |
|
@its-mitesh-kumar Tried the various edge cases to reproduce the issue: Added dummy items in:
But I was unable to reproduce it in every situation. As per your video, I have also tried disabling the Global Header. Tab-8-31-2025_13_48.mp4Can u share some more information on the reproduction steps? |
2e492b2 to
cfb6221
Compare
|
@Lucifergene I tested it again I can see the same issue adding the screen recording for the same. Screen.Recording.2025-09-03.at.8.53.51.AM.movI just did add below configuration. |
|
@its-mitesh-kumar I configured the nav items as you suggested, but it's still not reproducible. Tab-9-3-2025_09_32.mp4 |
|
@Lucifergene I tested it locally and observed the same behavior. The side scrollbar only becomes visible when scrolling, but it's not shown initially. I've attached a recording for your reference. Screen.Recording.2025-09-03.at.4.40.19.PM.mov |
|
The issue has been identified. Doing further tests on this. |
|
@its-mitesh-kumar Updated the scrollbar implementation to give the same feel across all OS and browsers. |
|
/lgtm |
|
/retest |
|
@HusneShabbir @Lucifergene is two lines above Administration visible to you too? @ShiranHi does this look good to you ? |
|
@its-mitesh-kumar Its because you have put the nav items in the top section. So you see both the lines together. |
We don't include a borderline after the last item "Nested tool9". |
|
@ShiranHi I think the existence of the borderline after NestedTool 9, is not related to this fix. |
its-mitesh-kumar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/retest-required |
1 similar comment
|
/retest-required |
|
/approve |
|
/retest |
1 similar comment
|
/retest |
christoph-jerolimov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of css but I guess its time to move forward here, thanks @Lucifergene for your patience.
/lgtm
/approve
8dd9d01 to
c2dc6ca
Compare
|
/lgtm |
|
The image is available at: |
|
/retest |
1 similar comment
|
/retest |
|
@Lucifergene: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Signed-off-by: Lucifergene <[email protected]>
Signed-off-by: Lucifergene <[email protected]>
Signed-off-by: Lucifergene <[email protected]>
Signed-off-by: Lucifergene <[email protected]>
c2dc6ca to
f8746e0
Compare
|
Just rebased to pass the e2e tests. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christoph-jerolimov, debsmita1, HusneShabbir, its-mitesh-kumar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
/test e2e-tests |
|
@christoph-jerolimov: The specified target(s) for The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
The image is available at: |
|
/test all |
03c5aba
into
redhat-developer:main





Fixes RHDHBUGS-262
Tab-8-1-2025_22_19.mp4