plugin for viewing and applying RedHat Insights recommendations

[ydayagi]

Hey, I just made a Pull Request!

✔️ Checklist

• A changeset describing the change and affected packages. (more info)
• Added or Updated documentation
• Tests for new functionality and regression tests for bug fixes
• Screenshots attached (for UI changes)

[rhdh-gh-app]

Important

This PR includes changes that affect public-facing API. Please ensure you are adding/updating documentation for new features or behavior.

Changed Packages

Package Name	Package Path	Changeset Bump	Current Version
app	workspaces/redhat-resource-optimization/packages/app	none	v0.0.5
backend	workspaces/redhat-resource-optimization/packages/backend	none	v0.0.5
@red-hat-developer-hub/plugin-redhat-resource-optimization-backend	workspaces/redhat-resource-optimization/plugins/redhat-resource-optimization-backend	major	v1.1.0
@red-hat-developer-hub/plugin-redhat-resource-optimization-common	workspaces/redhat-resource-optimization/plugins/redhat-resource-optimization-common	major	v1.1.0
@red-hat-developer-hub/plugin-redhat-resource-optimization	workspaces/redhat-resource-optimization/plugins/redhat-resource-optimization	major	v1.1.0

[jkilzi]

@ydayagi it requires minor changes. I left some comments to help you address the issues.

[BethGriggs]

I see this creates a new redhat-resource-optimization workspace in this repository. How does this relate to the workspace (redhat-resource-optimization) in the Backstage Community Plugins repository?

Before merging I'd just like to understand what the plan is, and whether it needs to be removed from Backstage Community Plugins to avoid having two divergent versions of the same plugin?

[ydayagi]

I see this creates a new redhat-resource-optimization workspace in this repository. How does this relate to the workspace (redhat-resource-optimization) in the Backstage Community Plugins repository?

Before merging I'd just like to understand what the plan is, and whether it needs to be removed from Backstage Community Plugins to avoid having two divergent versions of the same plugin?

sorry for the late response. just finished preparing the workspace with links to redhat.
this workspace is just as the orchestrator. another project in rhdh for redhat customers.
we have not intention to use or maintain the community repos

[BethGriggs]

we have not intention to use or maintain the community repos

@ydayagi, the plugin already exists in the Backstage Community Plugins (workspace) with Red Hat codeowners listed as active maintainers.

If there is no intention to maintain the version published in the community, can we please ensure the workspace is removed from there? The risk is that things like shared dependency update PRs that touch this workspace may become stuck waiting on review from those codeowners (so it can impact other maintainers in the project).

[ydayagi]

we have not intention to use or maintain the community repos

@ydayagi, the plugin already exists in the Backstage Community Plugins (workspace) with Red Hat codeowners listed as active maintainers.

If there is no intention to maintain the version published in the community, can we please ensure the workspace is removed from there? The risk is that things like shared dependency update PRs that touch this workspace may become stuck waiting on review from those codeowners (so it can impact other maintainers in the project).

sure. i will work on it and update you since it is ready

[ydayagi]

@BethGriggs here is the PR for removing from community plugins backstage/community-plugins#4185

[ydayagi]

@BethGriggs sonarCloud complains about code duplicity. can we ignore/bypass it? I did not find any duplicate code in the files it reports

Concern about the plugin living in two locations resolved

[BethGriggs]

@ydayagi, thanks for following up with the removal in the other repository. Dismissed my review as I just wanted to ensure the plugin didn't continue to exist in two places.

I'm personally not familiar with SonarCloud setup here, so may need someone else to comment on that.

[schultzp2020]

Just make sure to resolve the SonarQube code duplication issues and this should be ready!

[ydayagi]

Just make sure to resolve the SonarQube code duplication issues and this should be ready!

I have no idea how to do that. it is not clear where is the duplication and why it thinks there is a duplication

[ydayagi]

Just make sure to resolve the SonarQube code duplication issues and this should be ready!

@schultzp2020 Most of the duplicity is reported for files in the packages folder. Other plugins have the same file with similar content. I think that when the plugins were introduced for the first time, the SonarCloud report was ignored.

[ydayagi]

@nickboldt @davidfestal can u help me with sonarCloud?

seems like issues raised have been addressed.

[nickboldt]

Assuming that Paul is cool to merge this despite the slightly high dupe report from sonarqube cloud; with followup work TBD in https://issues.redhat.com/browse/RHIDP-7881

[nickboldt]

/lgtm
/approve

[openshift-ci]

New changes are detected. LGTM label has been removed.

[sonarqubecloud]

Quality Gate failed

Failed conditions
3.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud