Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos in RHDH documentation adocs #872

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jordanpagewhite
Copy link
Contributor

Hey RHDH team. I was just reviewing these docs since our platform team is doing some discovery on using RHDH internally at Red Hat to support our department (UXE). I bumped into a couple of typos that I thought I may as well help out with. I hope this helps!

@rhdh-bot
Copy link
Collaborator

Copy link
Member

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@nickboldt
Copy link
Member

@jordanpagewhite did you find these in the 1.3 or 1.4 published docs, or just in this GH repo? Wondering if we need to backport these typo fixes to the other docs too!

@jordanpagewhite
Copy link
Contributor Author

Hey @nickboldt I was reviewing the 1.4 docs since they are the most recent and relevant to my team's efforts. Thanks!

@nickboldt
Copy link
Member

/cherry-pick release-1.4

@openshift-cherrypick-robot
Copy link
Contributor

@nickboldt: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@linfraze linfraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm thank you for the fixes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants