Skip to content

RHIDP-7614: Configuring theme-specific company logos for global header and sidebar #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jmagak
Copy link
Member

@jmagak jmagak commented Jul 2, 2025

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Jul 2, 2025

@its-mitesh-kumar
Copy link
Member

We need to accommodate changes from
Theme Specific Logo in Global Header and Sidebar : redhat-developer/rhdh#3023

        - mountPoint: global.header/component
          importName: CompanyLogo
          config:
            priority: 200
            props:
              to: '/'
              logo: <string > or <object>
                 dark:
                 light: 

Sidebar Logo

app:
  sidebar:
    search: true
    settings: true
    logo: true
  branding:
    fullLogo: <string > or <object>
      dark: <image>
      light: <image>    

PR2: Setting the width and height of the CompanyLogo component through configuration : redhat-developer/rhdh-plugins#1068

- mountPoint: global.header/component
importName: CompanyLogo
config:
  priority: 200
  props:
    to: '/'
    logo:
      light: <image>
      dark: <image>
    width: 300
    height: 100
    

@jmagak
Copy link
Member Author

jmagak commented Jul 7, 2025

We need to accommodate changes from Theme Specific Logo in Global Header and Sidebar : redhat-developer/rhdh#3023

PR2: Setting the width and height of the CompanyLogo component through configuration : redhat-developer/rhdh-plugins#1068

Please check the updated sections with these suggestions, @its-mitesh-kumar.

@jmagak jmagak force-pushed the RHIDP-7614-Configuring-theme-specific-company-logos-for-global-header-and-sidebar branch from db2c706 to ec88c26 Compare July 7, 2025 12:41
@jmagak jmagak force-pushed the RHIDP-7614-Configuring-theme-specific-company-logos-for-global-header-and-sidebar branch from ec88c26 to c938115 Compare July 7, 2025 12:42
@jmagak jmagak force-pushed the RHIDP-7614-Configuring-theme-specific-company-logos-for-global-header-and-sidebar branch from c938115 to 4368613 Compare July 7, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants