Skip to content

RHIDP-7614: Displaying the preferred username and Company Logo #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 18, 2025
Merged

RHIDP-7614: Displaying the preferred username and Company Logo #1254

merged 9 commits into from
Aug 18, 2025

Conversation

jmagak
Copy link
Member

@jmagak jmagak commented Jul 2, 2025 •
edited
Loading

@jmagak jmagak requested a review from debsmita1 July 2, 2025 12:25
@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Jul 2, 2025 •
edited
Loading

Updated preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-1254/ @ 08/18/25 12:50:44

@debsmita1
Copy link
Member

@its-mitesh-kumar to review the compant logo

@debsmita1
Copy link
Member

profile display name LGTM !

@jmagak jmagak force-pushed the RHIDP-7614-Global-Header-Add-Company-Logo-and-User-profile-icon-support branch from 5997a85 to 1a6ae62 Compare July 9, 2025 07:58
@jmagak jmagak force-pushed the RHIDP-7614-Global-Header-Add-Company-Logo-and-User-profile-icon-support branch from 1a6ae62 to 2bc3691 Compare August 4, 2025 10:23
pabel-rh
pabel-rh reviewed Aug 6, 2025
View reviewed changes
@jmagak jmagak requested a review from pabel-rh August 8, 2025 13:42
@its-mitesh-kumar
Copy link
Member

@jmagak Also we need to add some documentation on how user can now enable the logo in sidebar.

its-mitesh-kumar
its-mitesh-kumar reviewed Aug 11, 2025
View reviewed changes
its-mitesh-kumar
its-mitesh-kumar reviewed Aug 18, 2025
View reviewed changes
@its-mitesh-kumar
Copy link
Member

/lgtm for Enabling Logo in Sidebar.

its-mitesh-kumar
its-mitesh-kumar reviewed Aug 18, 2025
View reviewed changes
Copy link
Member

@its-mitesh-kumar its-mitesh-kumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address below comments

its-mitesh-kumar
its-mitesh-kumar approved these changes Aug 18, 2025
View reviewed changes
Copy link
Member

@its-mitesh-kumar its-mitesh-kumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm for Both Company Logo in Global Header and Sidebar from Engineering Team.

@jmagak jmagak added Technical review done ⛅ Any procedure has been succesfully tested Ready to merge 💂 and removed do-no-merge/review-in-progress 👀 Technical review needed 🔩 Test all the procedures labels Aug 18, 2025
@pabel-rh pabel-rh merged commit 18d2e45 into redhat-developer:main Aug 18, 2025
3 checks passed
@pabel-rh
Copy link
Member

/cherry-pick release-1.7

@openshift-cherrypick-robot
Copy link
Contributor

@pabel-rh: #1254 failed to apply on top of branch "release-1.7":

Applying: Displaying the preferred username and Company Logo
Using index info to reconstruct a base tree...
M	assemblies/assembly-configuring-the-global-header.adoc
Falling back to patching base and 3-way merge...
Auto-merging assemblies/assembly-configuring-the-global-header.adoc
CONFLICT (content): Merge conflict in assemblies/assembly-configuring-the-global-header.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Displaying the preferred username and Company Logo

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pabel-rh
Copy link
Member

/cherry-pick release-1.7

@openshift-cherrypick-robot
Copy link
Contributor

@pabel-rh: #1254 failed to apply on top of branch "release-1.7":

Applying: Displaying the preferred username and Company Logo
Using index info to reconstruct a base tree...
M	assemblies/assembly-configuring-the-global-header.adoc
Falling back to patching base and 3-way merge...
Auto-merging assemblies/assembly-configuring-the-global-header.adoc
CONFLICT (content): Merge conflict in assemblies/assembly-configuring-the-global-header.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Displaying the preferred username and Company Logo

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

jmagak added a commit to jmagak/red-hat-developers-documentation-rhdh that referenced this pull request Aug 19, 2025
@jmagak
RHIDP-7614: Displaying the preferred username and Company Logo (redha…
25348bc 
…t-developer#1254)

* Displaying the preferred username and Company Logo

* Displaying the preferred username and Company Logo

* Displaying the preferred username and Company Log

* Displaying the preferred username and Company Log

* Displaying the preferred username and Company Log

* Displaying the preferred username and Company Log

* Displaying the preferred username and Company Log

---------

Co-authored-by: GitHub Actions <[email protected]>
@jmagak jmagak mentioned this pull request Aug 19, 2025
Merged
pabel-rh pushed a commit that referenced this pull request Aug 19, 2025
@jmagak
RHIDP-7614: Displaying the preferred username and Company Logo (#1254) (
8f84d5d 
#1312)

* Displaying the preferred username and Company Logo

* Displaying the preferred username and Company Logo

* Displaying the preferred username and Company Log

* Displaying the preferred username and Company Log

* Displaying the preferred username and Company Log

* Displaying the preferred username and Company Log

* Displaying the preferred username and Company Log

---------

Co-authored-by: GitHub Actions <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pabel-rh pabel-rh pabel-rh approved these changes

@debsmita1 debsmita1 Awaiting requested review from debsmita1

+1 more reviewer

@its-mitesh-kumar its-mitesh-kumar its-mitesh-kumar approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Peer review done 📘 Ready to merge 💂 Technical review done ⛅ Any procedure has been succesfully tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jmagak @rhdh-bot @debsmita1 @its-mitesh-kumar @pabel-rh @openshift-cherrypick-robot