Add Labels column to App, AppSet, ImageUpdater list pages; Remove TP badge (#10541) - #265
Add Labels column to App, AppSet, ImageUpdater list pages; Remove TP badge (#10541)#265keithchong wants to merge 2 commits into
Conversation
Signed-off-by: Keith Chong <kykchong@redhat.com>
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #265 +/- ##
==========================================
- Coverage 11.39% 11.15% -0.24%
==========================================
Files 168 168
Lines 6627 6669 +42
Branches 2274 2287 +13
==========================================
- Hits 755 744 -11
- Misses 5635 5685 +50
- Partials 237 240 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Keith Chong <kykchong@redhat.com>
aali309
left a comment
There was a problem hiding this comment.
LGTM, Thanks Keith.
Some optional polishing but definitely not blockers
- we should not use
yaml.stringifyfor label sort (unstable key order) - we should not hard-code maxWidth:
the 200pxon shared MetadataLabels
See GITOPS-10541 for details