Skip to content

Add Labels column to App, AppSet, ImageUpdater list pages; Remove TP badge (#10541) - #265

Open
keithchong wants to merge 2 commits into
redhat-developer:mainfrom
keithchong:10541-FixLabelsColumnAndSort
Open

Add Labels column to App, AppSet, ImageUpdater list pages; Remove TP badge (#10541)#265
keithchong wants to merge 2 commits into
redhat-developer:mainfrom
keithchong:10541-FixLabelsColumnAndSort

Conversation

@keithchong

Copy link
Copy Markdown
Collaborator

See GITOPS-10541 for details

Signed-off-by: Keith Chong <kykchong@redhat.com>
@openshift-ci
openshift-ci Bot requested review from aali309 and wtam2018 August 18, 2026 04:59
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Important

Review available on request

  • 🔍 Trigger review

Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment @coderabbitai review to review the latest changes. For a full review, comment @coderabbitai full review.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 59dd3bb3-3729-4d1c-bc94-2743493e3244


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

codecov-commenter commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 4.00000% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 11.15%. Comparing base (80b0f68) to head (c186f7d).
⚠️ Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
...itops/components/imageupdater/ImageUpdaterList.tsx 0.00% 6 Missing ⚠️
src/gitops/components/shared/ApplicationList.tsx 0.00% 6 Missing ⚠️
...rc/gitops/components/shared/ApplicationSetList.tsx 0.00% 6 Missing ⚠️
src/gitops/components/project/ProjectList.tsx 0.00% 3 Missing ⚠️
src/gitops/components/rollout/RolloutList.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #265      +/-   ##
==========================================
- Coverage   11.39%   11.15%   -0.24%     
==========================================
  Files         168      168              
  Lines        6627     6669      +42     
  Branches     2274     2287      +13     
==========================================
- Hits          755      744      -11     
- Misses       5635     5685      +50     
- Partials      237      240       +3     
Flag Coverage Δ
unit-tests 11.15% <4.00%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Keith Chong <kykchong@redhat.com>
@keithchong keithchong changed the title Add Labels column to App, AppSet, ImageUpdater list pages (#10541) Add Labels column to App, AppSet, ImageUpdater list pages; Remove TP badge (#10541) Aug 18, 2026

@aali309 aali309 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks Keith.
Some optional polishing but definitely not blockers

  1. we should not use yaml.stringify for label sort (unstable key order)
  2. we should not hard-code maxWidth: the 200px on shared MetadataLabels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants