feat: add vm_networking, vm_provision, vm_storage_labeling roles and security hardening#18
Open
stevefulme1 wants to merge 1 commit into
Open
feat: add vm_networking, vm_provision, vm_storage_labeling roles and security hardening#18stevefulme1 wants to merge 1 commit into
stevefulme1 wants to merge 1 commit into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
stevefulme1
changed the title
sabre1041
reviewed
Jul 2, 2026
There was a problem hiding this comment.
@stevefulme1 why did the content of this PR change/expand drastically? it now has a lot an rvtools integration that was not there previously
…security hardening Add three new roles: - vm_networking: manage network attachments via NADs - vm_provision: create VirtualMachines from specs - vm_storage_labeling: apply storage metadata labels Security improvements: - Default SSL verification to true across all playbooks - Add no_log to tasks handling API keys and Bearer tokens Also includes audit event_query extension, CI updates, and documentation improvements.
stevefulme1
force-pushed
the
feat/vm-storage-labeling
branch
from
2d48091 to
0eb2a29
Compare
stevefulme1
changed the title
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vm_networking(NAD-based network attachment),vm_provision(create VMs from specs),vm_storage_labeling(apply storage metadata labels)true, addno_logto credential-handling tasksvm_storage_labeling.ymlplaybook andevent_query.ymlaudit extensionNote: RVTools integration has been split to a separate PR.
Test plan
vm_storage_labelingrole applies labels correctlyvm_networkingattach/detach operationsvm_provisioncreates VMs from specstruein all playbooksansible-test sanity