Read Results API service metrics from api-for-watcher #5595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splitting the load of the Results API service, switched the watcher/controller related request to a new pod which handles most of the load. With the original service now used only by users, it gets much less load (that was the purpose), but it triggers some false positives from the monitoring service. Here we switch the ServiceMonitor to the new pods running most of the load.
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: enarha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
aThorp96
reviewed
Feb 18, 2025
There was a problem hiding this comment.
@enarha I'm worried that this could be a moving target, and could potentially cause the service monitor to falsely alert on request volume for the regular results-api service.
What do you think about instead doing the following, like we do with Tekton Chains:
- on the Results services, add the labels
app.kubernetes.io/component:withwatcherandapirespectively - switch the label selector to use
app.kubernetes.io/part-of: tekton-resultsandapp.kubernetes.io/component: api.
openshift-merge-bot
bot
merged commit 75a9306
into
redhat-appstudio:main
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting the load of the Results API service, switched the watcher/controller related request to a new pod which handles most of the load. With the original service now used only by users, it gets much less load (that was the purpose), but it triggers some false positives from the monitoring service. Here we switch the ServiceMonitor to the new pods running most of the load.