Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Staging] Change Tekton Vector collection to in-memory and ack enabled #5436

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

khrm
Copy link
Contributor

@khrm khrm commented Jan 30, 2025

This is to resolve missing logs issue.

Copy link
Contributor Author

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @enarha

@enarha
Copy link
Contributor

enarha commented Feb 2, 2025

/lgtm
/approve
/hold

Adding the hold label as we probably want to bump the memory limit to 3GB (.resources.requests.limits.memory). I was checking a prod instance and at regular load the memory usage was standing around 1 GB. Now with the in memory buffer, the usage will increase and it's better to avoid the OOM and pod restarts.

Copy link

openshift-ci bot commented Feb 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: enarha, khrm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@khrm
Copy link
Contributor Author

khrm commented Feb 3, 2025

@enarha I have updated the memory to 3GB.

@enarha
Copy link
Contributor

enarha commented Feb 3, 2025

/lgtm
/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit 8b8d27c into redhat-appstudio:main Feb 3, 2025
6 checks passed
khrm added a commit to khrm/infra-deployments that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants