Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP -Skip Record Readiness if annotated #13

Closed
wants to merge 2 commits into from

Conversation

kumaramit01
Copy link
Contributor

Closes #

💸 TL;DR

This PR adds support for infrared.reddit.com/skip-record-readiness annotation on a claim that will disable recording readiness metric.

📜 Details

Design Doc

Jira

🧪 Testing Steps / Validation

I need help unit testing this out.

✅ Checks

  • CI tests (if present) are passing
  • Adheres to code style for repo
  • Contributor License Agreement (CLA) completed if not a Reddit employee

@kumaramit01 kumaramit01 requested a review from a team as a code owner January 16, 2025 17:10
Copy link
Member

@jessicayuen jessicayuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kumaramit01 Commenting to clear my review queue, feel free to retag me once this is ready!

Copy link

@karanthukral karanthukral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleaning up queue for now. Feel free to retag when ready for review. Thanks

@kumaramit01
Copy link
Contributor Author

Decided in favor of #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants