fix: Read secrets from new collection #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, config secrets are stored in single-document collections that (in my experience) have names that don't clearly map to their usage. This starts reading them all out of a new collection named "secrets", and each document contains a single secret token.
|
I deployed this branch to the dev bot, and things still work! Specifically, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pairing Bot holds many secrets, and some of them are config values!
Right now, those config secrets are stored in single-document collections that (in my experience) have names that don't clearly map to their usage.
This starts reading them all out of a new collection named "secrets", and each document contains a single secret token.
I've already copied the secrets to their new locations, which can be verified in the Google Cloud console for both environments. (The RC API access token won't match, though, because I generated a new one out of my RC account.)
After both the dev and prod bots deploy successfully, I'll delete the old unused secret collections.