Merge DB fixes from dev #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want to be able to experiment with Pairing Bot locally, which means I'll need some way to run Firestore without also running all of Google Cloud. It turns out that there's an [emulator] inside of `gcloud` which is made exactly for this purpose! [emulator]: https://cloud.google.com/firestore/docs/emulator The Firestore Go SDK we're using automatically supports using this via the `FIRESTORE_EMULATOR_HOST` environment variable. ## Changes This sets up a single round-trip test to prove that this all works. I left space to add more because I'll be collecting them in the future as I learn about how Firestore works (and how we use it!). I also made these tests run on PRs to the `dev` branch. I intend to treat them as non-blocking there, but I do think it's nice to know that we've broken unit tests before deploying, even if it's just to the test bot. I also added a `dev.sh` script to help me remember how to start the emulator. It uses the same variable as the SDK so something like [direnv](https://direnv.net/) makes it "just work".
The Firestore client maintains its own internal gRPC connection pool and allows for its methods to be called concurrently. So we should be able to create just one client and reuse it everywhere we run Firestore queries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unified DB connection pool (#68) seems to work in test, so it's time to run it on
main.As a bonus, we also get integration tests (#64) running in CI!
I did a quick-fix (#70) directly to
main, so this gives us a little bit of a merge bubble. So in addition to the usual "promotedevtomain" (what this PR is), I'll also force-resetdevto match the newmainpost-merge.