Go version upgrade #107
Merged
Go version upgrade #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdkaplan
approved these changes
Dec 19, 2024
|
Happened to see this one, so I can put my stamp on it 😛 I noticed that deploys started failing after the (not technically necessary?) |
|
Yeah - I just wanted to get through the dependabot noise. The builder was failing with: Which...I dunno, did that change? I don't think we manually edited it. But, whatever let's see if this works... |
cceckman
added a commit
that referenced
this pull request
Dec 20, 2024
- Reverts prior changes (upgrade to 1.23 #107, `go get -u` #106), as 1.23 is not yet supported by the cloudbuild script. - Upgrade gRPC, due to missing go.sum entries in the stack. - Use `go mod tidy -go=1.22` to clean things up. - Read and specify the builder version in the cloudbuild files. The worker had been defaulting to 1.15, which didn't support point releases in module declarations. Tested on the dev environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since apparently the just-module rev didn't build.