Repository navigation
Make command output blocks and exit codes consistent - #147
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns how commands report results.
duplicated-code: empty state uses thesuccess()[OK] block (wasgreen()); findings summary uses theerror()block (wasredBackground()), matching the other detection commandsfind-multi-classes: add a closing summary block before returning error, so it ends like the other detectors instead of trailing off; also fix "1 classes"/"1 files" pluralssplit-config-per-package: it used to finish silently - now prints a success summary with the number of per-package files written and the output dir; also returnsExitCode::SUCCESSinstead of a literal0privatize-constants: informational counts and empty states no longer usesuccess()/warning()blocks that mismatched the exit code - neutral counts print plainly, empty states use a clear success messageNo exit-code behavior changes here (spot-lazy-traits was intentionally left out, since it is being removed in #146).
ECS and PHPStan pass.