String vs. Object Tags: Filter & Color Coding #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for recogito-cloud-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for vico-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rsimon
commented
Mar 7, 2025
| @@ -42,7 +42,7 @@ export const deleteInstalledPlugin = ( | |||
| export const updatePluginSettings = ( | |||
| supabase: SupabaseClient, | |||
| project_id: string, | |||
| plugin_id: string, | |||
| plugin_name: string, | |||
There was a problem hiding this comment.
I just added this while I was at it. This fixes a problem that plugin settings could not be updated from the "Settings" page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
When introducing the reconciliation plugin, we changed how tags are represented internally: Previously, tags were simply a string. Now they can be either a string, or an object
{ label: "a label", id: "an-id-or-uri" }.This PR fixes tag rendering in the filter panel and the color coding legend, which both used to render raw JSON instead of the label.