Minor readme change#1773
Conversation
|
@Shayan-Bhowmik is attempting to deploy a commit to the recode Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
Bot
added
in-review
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs. In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊 Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv. We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰 🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨ 📚Your perks for contribution to this community 👇🏻
If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
github-actions
Bot
added
enhancement
|
✅ Synchronized metadata from Issue #1715:
|
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the Docusaurus navbar branding and navigation styling, replacing the default logo component with a custom brand link and adjusting navbar iconography/CSS for dark mode.
Changes:
- Replaced
@theme/Navbar/Logowith a customNavbarBrandcomponent usingLink+useBaseUrl. - Tweaked navbar config to use symbol-based prefixes and adjusted logo
srcpath. - Added CSS for dark-mode logo visibility and a new
.nav-symbolutility class.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/theme/Navbar/Content/index.tsx | Introduces NavbarBrand and swaps it in for the default navbar logo component. |
| src/css/custom.css | Adds dark-mode logo styling and a .nav-symbol class to support updated navbar markup. |
| docusaurus.config.ts | Updates navbar logo path and replaces emoji prefixes with symbol-based markup/labels. |
| README.md | Minor formatting adjustment to closing tag alignment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| title: "recode hive", | ||
| logo: { | ||
| alt: "recode hive Logo", | ||
| src: "img/logo.png", | ||
| src: "/img/logo.png", |
| function NavbarBrand(): ReactNode { | ||
| const { siteConfig } = useDocusaurusContext(); | ||
| const logoConfig = siteConfig.themeConfig.navbar.logo; | ||
| const logoSrc = useBaseUrl(logoConfig?.src ?? "img/logo.png"); | ||
| const logoAlt = logoConfig?.alt ?? siteConfig.title; | ||
|
|
||
| return ( | ||
| <Link className="navbar__brand" to={useBaseUrl("/")} aria-label={siteConfig.title}> | ||
| <img className="navbar__logo" src={logoSrc} alt={logoAlt} /> | ||
| <strong className="navbar__title">{siteConfig.title}</strong> | ||
| </Link> | ||
| ); | ||
| } |
| html: '<span class="nav-symbol" aria-hidden="true">⌘</span> Devfolio', | ||
| position: "left", | ||
| items: [ | ||
| { | ||
| label: "💻GitHub Profiles", | ||
| label: "◆ GitHub Profiles", | ||
| to: "https://dev.recodehive.com/devfolio", | ||
| }, | ||
| { | ||
| label: "🎖️ GitHub Badges", | ||
| label: "▣ GitHub Badges", | ||
| to: "/badges/github-badges/", | ||
| }, | ||
| ], |
|
@Shayan-Bhowmik i can see there are some changes with multiple files , can we just move with minor readme changes alone ? |
sanjay-kv
added
level:critical
| } | ||
|
|
||
| /* Dark-mode-only navbar logo treatment so the brand mark stays visible on black navbars. */ | ||
| [data-theme="dark"] .navbar__logo { |
There was a problem hiding this comment.
these changes are not requested. you can just fix a grammer in the readme.md file and push
|
I dont understand please explain this to me, you closed the previous PR right? So how will you get the changes onto your website. This PR does a minor change in the readme, so even if you merge this you cant get those changes in the navbar I made. Sorry to drag this for so long but can you explain this to me. |
|
I think you can close this pr and I will put up another PR with only a small change in the readme and you can merge that. |
Closes #1715
Small readme change for the level 3 label.