Don't explicitly enable WebContentsDebugging#2657
Merged
fire-light42 merged 2 commits intorecloudstream:masterfrom Apr 14, 2026
Merged
Don't explicitly enable WebContentsDebugging#2657fire-light42 merged 2 commits intorecloudstream:masterfrom
fire-light42 merged 2 commits intorecloudstream:masterfrom
Conversation
https://developer.android.com/reference/android/webkit/WebView#setWebContentsDebuggingEnabled(boolean) "this is enabled automatically if the app is declared as `android:debuggable="true"` in its manifest; otherwise, the default is false." - which we set on CloudStream Debug but not release flavors. "Enabling web contents debugging allows the state of any WebView in the app to be inspected and modified by the user via adb. This is a security liability and should not be enabled in production builds of apps unless this is an explicitly intended use of the app."
fire-light42
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://developer.android.com/reference/android/webkit/WebView#setWebContentsDebuggingEnabled(boolean)
"this is enabled automatically if the app is declared as
android:debuggable="true"in its manifest; otherwise, the default is false." - which we set on CloudStream Debug but not release flavors."Enabling web contents debugging allows the state of any WebView in the app to be inspected and modified by the user via adb. This is a security liability and should not be enabled in production builds of apps unless this is an explicitly intended use of the app."