[SYCL][Graph] Update design doc for copy queue #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfrancepillois
added
the
Graph Implementation
mfrancepillois
requested review from
EwanC,
ori-sky,
reble,
Bensuo and
julianmi
Bensuo
force-pushed
the
maxime/update-doc-copy-queue
branch
2 times, most recently
from
7739b83 to
d5773eb
Compare
EwanC
approved these changes
May 31, 2024
EwanC
reviewed
May 31, 2024
I have added a test locally but actually the way it is right now the copy command list optimization will only happen for out-of-order command buffers. It might make sense to leave that as it is for now and work on combining these two optimizations if worth it as a further piece of work? |
Bensuo
force-pushed
the
maxime/update-doc-copy-queue
branch
from
73ba45c to
4a47e54
Compare
EwanC
reviewed
Jun 4, 2024
Bensuo
force-pushed
the
maxime/update-doc-copy-queue
branch
2 times, most recently
from
eb67857 to
020a5ff
Compare
EwanC
force-pushed
the
maxime/update-doc-copy-queue
branch
from
020a5ff to
0d13b58
Compare
- Update UR tag to include L0 command-buffer copy engine optimization - Add test which mixes copy and kernel commands - Update design doc to detail copy engine optimization
Co-authored-by: Kenneth Benzie (Benie) <[email protected]>
EwanC
force-pushed
the
maxime/update-doc-copy-queue
branch
from
5d44bdf to
01b1582
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the design doc as command-buffer now uses the copy queue if a copy engine is available.