Skip to content

Conversation

@lpozo
Copy link
Contributor

@lpozo lpozo commented Apr 1, 2025

Where to put new files:

  • New files should go into a top-level subfolder, named after the article slug. For example: my-awesome-article

How to merge your changes:

  1. Make sure the CI code style tests all pass (+ run the automatic code formatter if necessary).
  2. Find an RP Team member on Slack and ask them to review & approve your PR.
  3. Once the PR has one positive ("approved") review, GitHub lets you merge the PR.
  4. 🎉

@martin-martin martin-martin requested a review from Copilot April 8, 2025 12:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

python-uv/pyproject.toml:2

  • [nitpick] Consider renaming the project to better reflect the article slug or directory name (e.g., 'python-uv') for clarity.
name = "rpcats"

python-uv/pyproject.toml:4

  • [nitpick] Replace the placeholder project description with a meaningful description that aligns with the article's focus.
description = "Add your description here"

Copy link
Contributor

@martin-martin martin-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, one suggestion to sync the description with the one you use in your tutorial, and another optional one for the code.

@brendaweles brendaweles merged commit e1e1066 into master Apr 17, 2025
1 check passed
@brendaweles brendaweles deleted the python-uv branch April 17, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants