Skip to content

Conversation

@martin-martin
Copy link
Contributor

Where to put new files:

  • New files should go into a top-level subfolder, named after the article slug. For example: my-awesome-article

How to merge your changes:

  1. Make sure the CI code style tests all pass (+ run the automatic code formatter if necessary).
  2. Find an RP Team member on Slack and ask them to review & approve your PR.
  3. Once the PR has one positive ("approved") review, GitHub lets you merge the PR.
  4. 🎉

Copy link
Contributor

@stephengruppetta stephengruppetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martin-martin @gahjelle, nothing much to review in the materials repo. I confirm all three lines are fine (!!)
I know the policy is to always have downloadable material with tutorials, but could such a brief three-liner do more harm than good?

@martin-martin
Copy link
Contributor Author

martin-martin commented Oct 30, 2024

@stephengruppetta I don't think it'll do more harm than good. I think it probably doesn't do much good from a learning perspective either, but if it makes a reader sign up, that's good.

Providing materials that go above and beyond content that we already have through making the tutorial hasn't seemed like a worthwhile time investment from a company perspective so far.

@brendaweles brendaweles merged commit 6726c6a into master Nov 4, 2024
1 check passed
@brendaweles brendaweles deleted the interacting-update branch November 4, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants